twalthr commented on a change in pull request #18088:
URL: https://github.com/apache/flink/pull/18088#discussion_r770423759
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -620,10 +620,16 @@ public static String getFormatPrefix(
Class<T> factoryClass, DynamicTableFactory.Context context) {
final String connectorOption =
context.getCatalogTable().getOptions().get(CONNECTOR.key());
if (connectorOption == null) {
- throw new ValidationException(
- String.format(
- "Table options do not contain an option key '%s'
for discovering a connector.",
- CONNECTOR.key()));
+ ManagedTableFactory factory =
Review comment:
tbh I also don't like the empty string. A `managed-table` or even
`default` (which we use for planner and executor discovery) would be nicer and
looks less like a bug. `default` would ensure consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
