dawidwys commented on a change in pull request #18092:
URL: https://github.com/apache/flink/pull/18092#discussion_r770436638
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1200,92 +1200,69 @@ public boolean receiveAcknowledgeMessage(
*/
private void completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
throws CheckpointException {
- final long checkpointId = pendingCheckpoint.getCheckpointId();
+ final long checkpointId = pendingCheckpoint.getCheckpointID();
final CompletedCheckpoint completedCheckpoint;
+ final CompletedCheckpoint lastSubsumed;
+ final CheckpointProperties props = pendingCheckpoint.getProps();
// As a first step to complete the checkpoint, we register its state
with the registry
- Map<OperatorID, OperatorState> operatorStates =
pendingCheckpoint.getOperatorStates();
- SharedStateRegistry sharedStateRegistry =
completedCheckpointStore.getSharedStateRegistry();
- sharedStateRegistry.registerAll(operatorStates.values());
-
- long lastSubsumedCheckpointId =
CheckpointStoreUtil.INVALID_CHECKPOINT_ID;
+ // we do not
Review comment:
Yes, it is unfinished :sweat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
