pnowojski commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r770498612
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -177,11 +179,27 @@ public IncrementalRocksDBSnapshotResources
syncPrepareResources(long checkpointI
return registry -> SnapshotResult.empty();
}
+ final Set<StateHandleID> baseSstFiles;
+ final CheckpointType.SharingFilesStrategy sharingFilesStrategy =
+
checkpointOptions.getCheckpointType().getSharingFilesStrategy();
+ switch (sharingFilesStrategy) {
+ case FORWARD_BACKWARD:
+ baseSstFiles = snapshotResources.baseSstFiles;
+ break;
+ case FORWARD:
+ case NO_SHARING:
Review comment:
Does this code support `NO_SHARING` mode at the moment? I think newly
created files will be used in future snapshots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
