matriv opened a new pull request #18135:
URL: https://github.com/apache/flink/pull/18135
## What is the purpose of the change
Fix precision for agg functions on decimal types.
## Brief change log
- Small code optimisations for aggregate functions
- Fix existing test for `SumWithRetractAggFunction` which didn't actually
use it but instead used the normal `SumAggFunction`.
- Since `Sum0AggFunction`,`SumWithRetractAggFunction` and `AvgAggFunction`
are using internally `plus()` and `minus()` operatora to implement the sum and
avg aggregation (`minus()` is used also for the `WithRetract`), the decimal
return type calculated by `LogicalTypeMerging#findSumAggType()` and
`LogicalTypeMerging#findiAvgAggType()` gets overriden by the calculation for
the `plus()` (and/or `minus()`) operator done by
`LogicalTypeMerging#findAdditionDecimalType()`. To prevent this add a special
`aggDecimalMinus()` operator and use it together with the previously added
`aggDecimalPlus()` in those aggregate functions to avoid overriding the
calculated precision of their decimal return type.
## Verifying this change
This change added tests and can be verified as follows:
- Added tests to `AggregateITCase.scala` both for SQL and TableApi.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
