[
https://issues.apache.org/jira/browse/FLINK-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-11372:
-----------------------------------
Labels: auto-deprioritized-major auto-unassigned pull-request-available
stale-minor (was: auto-deprioritized-major auto-unassigned
pull-request-available)
I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help
the community manage its development. I see this issues has been marked as
Minor but is unassigned and neither itself nor its Sub-Tasks have been updated
for 180 days. I have gone ahead and marked it "stale-minor". If this ticket is
still Minor, please either assign yourself or give an update. Afterwards,
please remove the label or in 7 days the issue will be deprioritized.
> Incorrect delegation of compatibility checks to new snapshots in
> CollectionSerializerConfigSnapshot
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-11372
> URL: https://issues.apache.org/jira/browse/FLINK-11372
> Project: Flink
> Issue Type: Bug
> Components: API / Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Priority: Minor
> Labels: auto-deprioritized-major, auto-unassigned,
> pull-request-available, stale-minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In {{CollectionSerializerConfigSnapshot}}:
> {code}
> @Override
> public TypeSerializerSchemaCompatibility<C>
> resolveSchemaCompatibility(TypeSerializer<C> newSerializer) {
> if (newSerializer instanceof ListSerializer) {
> ListSerializer<T> newListSerializer = (ListSerializer<T>)
> newSerializer;
> ListSerializerSnapshot<T> listSerializerSnapshot = new
> ListSerializerSnapshot<>(newListSerializer);
> @SuppressWarnings("unchecked")
> TypeSerializerSchemaCompatibility<C> result =
> (TypeSerializerSchemaCompatibility<C>)
>
> listSerializerSnapshot.resolveSchemaCompatibility(newListSerializer);
> return result;
> } else {
> return super.resolveSchemaCompatibility(newSerializer);
> }
> }
> {code}
> Compatibility check of {{ListSerializer}} is delegated to the new list
> serializer snapshot class, {{ListSerializerSnapshot}}.
> However, it is incorrect to let the delegate wrap the new serializer (and
> therefore the new nested element serializer). By doing that, we're
> essentially checking compatibility of the new serializer with itself, whereas
> it should be checking compatibility with the restored serializer.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
