slinkydeveloper commented on a change in pull request #18151:
URL: https://github.com/apache/flink/pull/18151#discussion_r772224128
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/table/DataGeneratorConnectorITCase.java
##########
@@ -71,4 +71,19 @@ public void testTypes() throws Exception {
Assert.assertEquals("Unexpected number of results", 10,
results.size());
}
+
+ @Test
+ public void testLimit() throws Exception {
+ tEnv().executeSql(TABLE);
+
+ List<Row> results = new ArrayList<>();
+
+ try (CloseableIterator<Row> iter = tEnv().executeSql("select * from
datagen_t limit 5").collect()) {
Review comment:
Agree with @Airblader, please add a test with a new table definition
that does not include `number-of-rows`, as it also tests that the validation
phase doesn't fail because of missing `number-of-rows`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
