slinkydeveloper commented on a change in pull request #18152:
URL: https://github.com/apache/flink/pull/18152#discussion_r772275836
##########
File path:
flink-python/src/main/java/org/apache/flink/table/runtime/operators/python/AbstractStatelessFunctionOperator.java
##########
@@ -53,17 +51,11 @@
/** The input logical type. */
protected final RowType inputType;
- /** The output logical type. */
- protected final RowType outputType;
-
- /** The offsets of user-defined function inputs. */
- protected final int[] userDefinedFunctionInputOffsets;
-
/** The user-defined function input logical type. */
- protected transient RowType userDefinedFunctionInputType;
+ protected final RowType userDefinedFunctionInputType;
/** The user-defined function output logical type. */
- protected transient RowType userDefinedFunctionOutputType;
+ protected final RowType userDefinedFunctionOutputType;
Review comment:
I prefer to keep `GeneratedProjection` as it clashes with `Projection`
otherwise (e.g. see `groupKeyProjection` in
`AbstractBatchArrowPythonAggregateFunctionOperator`), for the others i will
change them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
