CrynetLogistics commented on a change in pull request #18022:
URL: https://github.com/apache/flink/pull/18022#discussion_r772496328
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -87,6 +88,20 @@ public static CredentialProvider getCredentialProviderType(
}
}
+ /**
+ * Return a {@link AwsCredentialsProvider} instance corresponding to the
configuration
+ * properties.
+ *
+ * @param configProps the configuration property map
+ * @return The corresponding AWS Credentials Provider instance
+ */
+ public static AwsCredentialsProvider getCredentialsProvider(final
Map<String, ?> configProps) {
+ Properties properties = new Properties();
+ properties.putAll(configProps);
+
+ return getCredentialsProvider(properties,
AWSConfigConstants.AWS_CREDENTIALS_PROVIDER);
Review comment:
nit: would `return getCredentialsProvider(properties);` be nicer for
this line (using the helper on line 112)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
