alpreu commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-999604274
I just pushed a work in progress commit that illustrates the idea. One thing I really don't like is that `getClusterId()` cannot be hidden/private because: 1) it needs the reference to the flink Configuration object 2) it is used to retrieve the (unmodified) clusterId in a lot of places I tried to change that but almost all of the classes extending `AbstractKubernetesStepDecorator` provide some static method to retrieve the label (e.g. `getFlinkConfigMapName` that takes the clusterId as string input because they are also called with the string input provided by the CLI. TLDR: I'm not really happy with the solution right now and the problem is more tricky than it looks. Do you guys have any ideas how we can clean this up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
