[ 
https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463847#comment-17463847
 ] 

Martijn Visser commented on FLINK-25409:
----------------------------------------

[~wenlong.lwl] I do think it is relevant. A connector should be available for 
both DataStream and Table/SQL users and share as much code as possible. There 
are of course specific implementation details for either DataStream and 
Table/SQL, but those should hopefully just be a thin layer that's connecting 
interfaces together. That also means that we should have a generic 
implementation in the Source API to enable lookups for connectors for which 
that's relevant, such as JDBC or HBase etc. Metrics could then come out of the 
box instead of a connector by connector implementation. 

> Add cache metric to LookupFunction
> ----------------------------------
>
>                 Key: FLINK-25409
>                 URL: https://issues.apache.org/jira/browse/FLINK-25409
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Ecosystem
>            Reporter: Yuan Zhu
>            Priority: Major
>
> Since we encounter performance problem when lookup join in production env 
> frequently, adding metrics to monitor Lookup function cache is very helpful 
> to troubleshoot.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to