MartijnVisser commented on a change in pull request #18180:
URL: https://github.com/apache/flink/pull/18180#discussion_r774116459
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStreamUtils.java
##########
@@ -122,7 +122,7 @@
final ClientAndIterator<E> clientAndIterator =
collectWithClient(stream, jobName);
final List<E> result =
collectRecordsFromUnboundedStream(clientAndIterator, numElements);
- // cancel the job not that we have received enough elements
+ // cancel the job note that we have received enough elements
Review comment:
I hope that when a PR is submitted for a fix, that the contributor knows
what's meant in this case. Else, how do you that the PR is an improvement? So
that means checking out what the test does and fixing (if applicable) the
comment.
Do note that this is a comment typo fix only: that means that the impact and
value of this PR is limited because it the impact for the Flink user or
developer is super small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
