wsry commented on pull request #18173:
URL: https://github.com/apache/flink/pull/18173#issuecomment-1000066327


   > I wonder if we should actually clean up the lock acquisition in the local 
and global buffer pools? For example enforce a strict contract, that if the 
global lock has to be acquired, it has to be acquired always before taking any 
local buffer pool lock?
   
   I think it is a good idea. Maybe we can pass the local pool instance or some 
abstract interface to ```NetworkBufferPool``` when calling any 
```NetworkBufferPool``` method, then check if the corresponding lock is locked 
before acquiring the ```NetworkBufferPool``` lock, though maybe in a different 
PR. WDYT, any suggestion about that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to