matriv commented on a change in pull request #18162:
URL: https://github.com/apache/flink/pull/18162#discussion_r774479369
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -656,6 +656,13 @@
.fromCaseLegacy(CHAR(6), fromString("Apache"),
fromString("Apache"))
.fromCase(VARCHAR(5), fromString("Flink"),
fromString("Flink "))
.fromCaseLegacy(VARCHAR(5), fromString("Flink"),
fromString("Flink"))
+ // We assume that the input length is respected,
therefore, no trimming is
+ // applied
+ .fromCase(CHAR(2), fromString("Apache"),
fromString("Apache"))
+ .fromCaseLegacy(CHAR(2), fromString("Apache"),
fromString("Apache"))
+ .fromCase(VARCHAR(2), fromString("Apache"),
fromString("Apache"))
+ .fromCaseLegacy(VARCHAR(2), fromString("Apache"),
fromString("Apache"))
+ //
Review comment:
I used it to mark the end of that section, since there are more tests
for this target type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
