lindong28 commented on a change in pull request #43: URL: https://github.com/apache/flink-ml/pull/43#discussion_r774573603
########## File path: tools/releasing/create_python_sdk_release.sh ########## @@ -0,0 +1,81 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +## +## Variables with defaults (if not overwritten by environment) +## +SKIP_GPG=${SKIP_GPG:-false} +MVN=${MVN:-mvn} + +## +## Required variables +## +RELEASE_VERSION=${RELEASE_VERSION} + +if [ -z "${RELEASE_VERSION}" ]; then + echo "RELEASE_VERSION was not set." + exit 1 +fi + +# fail immediately +set -o errexit +set -o nounset + +if [ "$(uname)" == "Darwin" ]; then + SHASUM="shasum -a 512" +else + SHASUM="sha512sum" +fi + +CURR_DIR=`pwd` +BASE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" +PROJECT_ROOT="${BASE_DIR}/../../" + +# Sanity check to ensure that resolved paths are valid; a LICENSE file should aways exist in project root +if [ ! -f ${PROJECT_ROOT}/LICENSE ]; then + echo "Project root path ${PROJECT_ROOT} is not valid; script may be in the wrong directory." + exit 1 +fi + +########################### + +RELEASE_DIR=${PROJECT_ROOT}/release/ +mkdir -p ${RELEASE_DIR} + +cd ${PROJECT_ROOT}/flink-ml-python-sdk/ Review comment: After going through the `create_python_sdk_release.sh` used by flink-statefun, I realize that the development of this script depends a lot on the directory structure of flink-ml-python. Since I am not the developer of flink-ml-python and I have not experience with python release, it is probably better for someone else to create this script for Flink ML. I have removed this script from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
