[
https://issues.apache.org/jira/browse/FLINK-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386005#comment-15386005
]
ASF GitHub Bot commented on FLINK-3956:
---------------------------------------
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2270
[FLINK-3956] Make FileInputFormats independent from Configuration
This PR makes all the parameters from the input formats accessible through
setters.
Before, some could only be set through a configuration object that was
passed in the
`configure()` method. This was problematic because in streaming, this
configuration
object is overwritten by a new configuration object with the default
values, as it travels
from the client to the task managers, leading to parameters like the
`enumerateNestedFiles` flag in the `FileInputFormat` not being able to be
set to a
non-default value.
NOTE: Now, values set by the setters overwrite the ones in the
configuration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink if_config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2270
----
commit e7ad5fdb32842036d5b1366132d95bd6db764942
Author: kl0u <[email protected]>
Date: 2016-07-18T16:18:43Z
[FLINK-3956] Make FileInputFormats independent from Configuration
Parameters of some input formats that was only possible to be
set through the Configuration object now have setter methods
that allow the user to do so.
Values set by the setters cannot be reset by the configuration
object.
----
> Make FileInputFormats independent from Configuration
> ----------------------------------------------------
>
> Key: FLINK-3956
> URL: https://issues.apache.org/jira/browse/FLINK-3956
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
>
> Currently many input file input formats rely on a user specified
> Configuration object for their correct configuration. As an example, the
> DelimitedInputFormat can take its delimiter character from this object.
> This is happening for legacy reasons, and does not work in the streaming
> codebase. In streaming, the user-specified configuration object is
> over-written at the TaskManagers by a new Configuration object.
> This issue aims at solving this by refactoring current file input formats to
> be
> able to set their parameters through setters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
