[
https://issues.apache.org/jira/browse/FLINK-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386045#comment-15386045
]
ASF GitHub Bot commented on FLINK-4231:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2272
[FLINK-4231] [java] Switch DistinctOperator from GroupReduce to Reduce
Rewrite the DistinctOperator using Reduce to support both the sort-based
combine and the recently added hash-based combine. This is configured by the
new method DistinctOperator.setCombineHint(CombineHint).
The tests for combineability are removed as Reduce is inherently
combineable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
4231_switch_distinctoperator_from_groupreducefunction_to_reducefunction
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2272
----
commit 2405f827d672d669ab0d5cc8d5963928b13511be
Author: Greg Hogan <[email protected]>
Date: 2016-07-18T15:50:44Z
[FLINK-4231] [java] Switch DistinctOperator from GroupReduce to Reduce
Rewrite the DistinctOperator using Reduce to support both the sort-based
combine and the recently added hash-based combine. This is configured by
the new method DistinctOperator.setCombineHint(CombineHint).
The tests for combineability are removed as Reduce is inherently
combineable.
----
> Switch DistinctOperator from GroupReduce to Reduce
> --------------------------------------------------
>
> Key: FLINK-4231
> URL: https://issues.apache.org/jira/browse/FLINK-4231
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
>
> As discussed in FLINK-3279, rewriting {{DistinctOperator}} to a
> {{ReduceFunction}} rather than the current {{GroupReduceFunction}} allows the
> user to set the {{CombineHint}} and choose a hash-based, sort-based, or no
> combiner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
