SteNicholas commented on a change in pull request #17994:
URL: https://github.com/apache/flink/pull/17994#discussion_r774941544
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java
##########
@@ -158,6 +158,13 @@
.withDescription(
"Optional offsets used in case of
\"specific-offsets\" startup mode");
+ public static final ConfigOption<String> SCAN_BOUNDED_SPECIFIC_OFFSETS =
+ ConfigOptions.key("scan.bounded.specific-offsets")
Review comment:
```suggestion
ConfigOptions.key("scan.bounded.stop-offsets")
```
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSource.java
##########
@@ -161,6 +164,7 @@ public KafkaDynamicSource(
Map<KafkaTopicPartition, Long> specificStartupOffsets,
long startupTimestampMillis,
boolean upsertMode,
+ Map<KafkaTopicPartition, Long> boundedEndOffsets,
Review comment:
```suggestion
Map<KafkaTopicPartition, Long> stopOffsets,
```
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java
##########
@@ -578,6 +599,7 @@ static void validateDeliveryGuarantee(ReadableConfig
tableOptions) {
public StartupMode startupMode;
public Map<KafkaTopicPartition, Long> specificOffsets;
public long startupTimestampMillis;
+ public Map<TopicPartition, Long> setBounded;
Review comment:
The name of this variable is confusing. Could you please make a better
name?
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java
##########
@@ -158,6 +158,13 @@
.withDescription(
"Optional offsets used in case of
\"specific-offsets\" startup mode");
+ public static final ConfigOption<String> SCAN_BOUNDED_SPECIFIC_OFFSETS =
+ ConfigOptions.key("scan.bounded.specific-offsets")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "When all partitions have reached their stop
offsets, the source will exit");
Review comment:
The description is certain confusing which you should describe that the
bounded source could be specificed by setting the stop offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
