[
https://issues.apache.org/jira/browse/FLINK-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465544#comment-17465544
]
Dong Lin commented on FLINK-25368:
----------------------------------
Thanks for the creating the ticket to improve Flink!
I think the overall motivation makes sense. But the PR changed
OffsetsInitializer::PartitionOffsetsRetriever and OffsetsInitializer is marked
@PublicEvolving. We probably need to file a FLIP for any public API change like
this.
This ticket focuses on refactoring the existing class without providing extra
functionality directly. my gut feel is that we can do this refactor only when
we really need the extra functionality. Then we will need to describe the
motivation and the scenario in the FLIP.
> Use AdminClient to get offsets rather than KafkaConsumer
> --------------------------------------------------------
>
> Key: FLINK-25368
> URL: https://issues.apache.org/jira/browse/FLINK-25368
> Project: Flink
> Issue Type: Improvement
> Reporter: dengziming
> Priority: Minor
> Labels: pull-request-available
>
> `AdminClient.listOffsets` is provided in Kafka 2.7, In the future more
> `OffsetSpce` types will be added to it, for example,
> OffsetSpec.MaxTimestampSpec is added in Kafka 3.0. so it's better to
> substitute `KafkaConsumer` with `AdminClient`.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
