lindong28 commented on pull request #18145: URL: https://github.com/apache/flink/pull/18145#issuecomment-1001365705
Thanks for the creating the ticket to improve Flink! I think the overall motivation makes sense. But the PR changed OffsetsInitializer::PartitionOffsetsRetriever and OffsetsInitializer is marked @PublicEvolving. We probably need to file a FLIP for any public API change like this. This PR focuses on refactoring the existing class without providing extra functionality directly. my gut feel is that we can do this refactor only when we really need the extra functionality. Then we will need to describe the motivation and the scenario in the FLIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
