tillrohrmann commented on a change in pull request #18211:
URL: https://github.com/apache/flink/pull/18211#discussion_r775841680



##########
File path: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
##########
@@ -92,6 +98,12 @@
     @ClassRule
     public static final CassandraContainer CASSANDRA_CONTAINER = 
createCassandraContainer();
 
+    private static final int MAX_CONNECTION_RETRY = 3;
+    private static final int CONNECTION_RETRY_DELAY = 500;

Review comment:
       nit ```suggestion
       private static final long CONNECTION_RETRY_DELAY = 500L;
   ```

##########
File path: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
##########
@@ -83,7 +88,8 @@
 
 /** IT cases for all cassandra sinks. */
 @SuppressWarnings("serial")
-@Ignore(value = "Flaky test")
+// NoHostAvailableException is raised by Cassandra client under load while 
connecting to the cluster
+@RetryOnException(times = 3, exception = NoHostAvailableException.class)

Review comment:
       Why is this needed if we have the retry logic in the setup method? The 
JIRA reads as if the `NoHostAvailableException` only occurs when the client 
connects to Cassandra. Can this also happen after the `session` is established?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to