[ 
https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387820#comment-15387820
 ] 

ASF GitHub Bot commented on FLINK-4229:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2279#discussion_r71720105
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java 
---
    @@ -88,7 +88,7 @@ public void testPortConflictHandling() throws Exception {
                JMXReporter rep2 = new JMXReporter();
     
                Configuration cfg1 = new Configuration();
    -           cfg1.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, 
"-port 9020-9035");
    +           cfg1.setString("port", "9020-9035");
    --- End diff --
    
    The change of only starting a server when the ports are present should not 
change the config keys, correct?


> Do not start Metrics Reporter by default
> ----------------------------------------
>
>                 Key: FLINK-4229
>                 URL: https://issues.apache.org/jira/browse/FLINK-4229
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.1.0
>
>
> By default, we start a JMX reported that binds to a port and comes with extra 
> threads. 
> We should not start any reported by default to keep the overhead to a minimum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to