pnowojski commented on a change in pull request #18068:
URL: https://github.com/apache/flink/pull/18068#discussion_r776320425
##########
File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -230,19 +230,19 @@ Flink currently only provides processing guarantees for
jobs without iterations.
Please note that records in flight in the loop edges (and the state changes
associated with them) will be lost during failure.
-## Checkpointing with parts of the graph finished *(BETA)*
+## Checkpointing with parts of the graph finished
Starting from Flink 1.14 it is possible to continue performing checkpoints
even if parts of the job
-graph have finished processing all data, which might happen if it contains
bounded sources. This
-feature must be enabled via a feature flag:
+graph have finished processing all data, which might happen if it contains
bounded sources. This feature
+is enabled by default since 1.15, and it could be configured by
Review comment:
```suggestion
is enabled by default since 1.15, and it could be disabled via a feature
flag:
```
##########
File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -230,19 +230,19 @@ Flink currently only provides processing guarantees for
jobs without iterations.
Please note that records in flight in the loop edges (and the state changes
associated with them) will be lost during failure.
-## Checkpointing with parts of the graph finished *(BETA)*
+## Checkpointing with parts of the graph finished
Starting from Flink 1.14 it is possible to continue performing checkpoints
even if parts of the job
-graph have finished processing all data, which might happen if it contains
bounded sources. This
-feature must be enabled via a feature flag:
+graph have finished processing all data, which might happen if it contains
bounded sources. This feature
+is enabled by default since 1.15, and it could be configured by
```java
Configuration config = new Configuration();
config.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH,
true);
Review comment:
```suggestion
config.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH,
false);
```
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java
##########
@@ -617,7 +617,6 @@ private static JobGraph createJobGraphWithOperatorState(
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.setParallelism(parallelism);
env.getConfig().setMaxParallelism(maxParallelism);
- env.enableCheckpointing(Long.MAX_VALUE);
Review comment:
Is this relevant change?
##########
File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -83,7 +83,7 @@ Other parameters for checkpointing include:
- *unaligned checkpoints*: You can enable [unaligned checkpoints]({{< ref
"docs/ops/state/checkpointing_under_backpressure" >}}#unaligned-checkpoints) to
greatly reduce checkpointing times under backpressure. This only works for
exactly-once checkpoints and with one concurrent checkpoint.
- - *checkpoints with finished tasks*: You can enable an experimental feature
to continue performing checkpoints even if parts of the DAG have finished
processing all of their records. Before doing so, please read through some
[important considerations](#checkpointing-with-parts-of-the-graph-finished).
+ - *checkpoints with finished tasks*: By default Flink could continue
performing checkpoints even if parts of the DAG have finished processing all of
their records. Please refer to [important
considerations](#checkpointing-with-parts-of-the-graph-finished) for details.
Review comment:
```suggestion
- *checkpoints with finished tasks*: By default Flink will continue
performing checkpoints even if parts of the DAG have finished processing all of
their records. Please refer to [important
considerations](#checkpointing-with-parts-of-the-graph-finished) for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
