LadyForest opened a new pull request #18236: URL: https://github.com/apache/flink/pull/18236
## What is the purpose of the change This PR is a foundation of FLINK-25176 that introduces the SQL syntax `ALTET TABLE table_identifier [PARTITION partition_spec] COMPACT`, which paves the way for coordination with managed table storage launching a job to compact manifest files. You can find more details at [FLIP-188](https://cwiki.apache.org/confluence/display/FLINK/FLIP-188%3A+Introduce+Built-in+Dynamic+Table+Storage). ## Brief changelog - Extend `Parser.tdd` and `parserImpls.ftl` templates for flink-sql-parser to support syntax. Add `SqlAlterTableCompact` as the representition after parsing. - Extend `SqlToOperationConverter` to support operation transformation. The converter imposes a check on the underlying table is a Flink's managed table and throws a `UnsupportedOperationException` if it is a non-managed one. The converter also checks the partition spec and throws a `ValidationException` if the partition_spec is invalid. - In addition, this PR also tries to - fix typo in `UseCatalogOperation` - fix incorrect `{@link}` in `PartitioningSpec` (which I've confirmed with @godfreyhe) - unify the `asSummaryString` method across `AlterTableDropConstraintOperation` and `SqlToOperationConverter` to use `tableIdentifier.asSummaryString` because `tableIdentifier.toStirng` is implicitly call `tableIdentifier.asSerializableString` - migrate all tests in`SqlToOperationConverterTest` to assertJ ## Verifying this change This change added tests and can be verified as follows: - *Added test in `FlinkSqlParserImplTest` to verify the syntax parsing* - *Added test in `SqlToOperationConverterTest` to verify the operation conversion* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
