lindong28 commented on a change in pull request #46:
URL: https://github.com/apache/flink-ml/pull/46#discussion_r776566846
##########
File path: README.md
##########
@@ -1,12 +1,12 @@
-Flink ML is a library which provides machine learning (ML) APIs and libraries
that simplify the building of machine learning pipelines. It provides a set of
standard ML APIs for MLlib developers to implement ML algorithms, as well as
libraries of ML algorithms that can be used to build ML pipelines for both
training and inference jobs.
+Flink ML is a library which provides machine learning (ML) APIs and a set of
ML algorithms that simplifies the building of ML pipelines. Users can implement
ML algorithms with the standard ML APIs and further use these algorithms to
build ML pipelines for both training and inference jobs.
Review comment:
The flink-ml-core provides not just API, but also `libraries that
simplify the building of machine learning pipelines`.
Could you add it back?
##########
File path: flink-ml-core/src/main/resources/META_INF/licenses/MIT.license
##########
@@ -0,0 +1,7 @@
+Copyright <YEAR> <COPYRIGHT HOLDER>
Review comment:
Follow the pattern of the existing license files added in Flink, we need
to copy the LICENSE from the `dev.ludovic.netlib:blas` repo and name this file
`LICENSE.blas`.
##########
File path: flink-ml-core/src/main/resources/META_INF/NOTICE
##########
@@ -1,10 +1,10 @@
-flink-ml-uber
+flink-ml-core
Review comment:
Why do we change it? I think this should refer to the module name (i.e.
`flink-ml-uber`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
