Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71882489
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -651,14 +651,38 @@
// ---------------------------- Metrics
-----------------------------------
+ // Per reporter:
+
+ /**
+ * The list of named reporters. Names are defined here and per-reporter
configs
+ * are given with the reporter config prefix and the reporter name.
+ *
+ * Example:
+ * <pre>{@code
+ * metrics.reporters = foo, bar
+ *
+ * metrics.reporter.foo.class = FooReporter.class
+ * metrics.reporter.foo.interval = 10
+ *
+ * metrics.reporter.bar.class = JMXReporter.class
+ * metrics.reporter.bar.port = 1337
+ * }</pre>
+ */
+ public static final String METRICS_REPORTERS_LIST = "metrics.reporters";
+
+ /**
+ * The prefix for per-reporter configs. Has to be combined with a
reporter name and
+ * the configs mentioned below.
+ */
+ public static final String METRICS_REPORTER_PREFIX =
"metrics.reporter.";
+
/** The class of the reporter to use. */
- public static final String METRICS_REPORTER_CLASS =
"metrics.reporter.class";
-
- /** A list of named parameters that are passed to the reporter. */
- public static final String METRICS_REPORTER_ARGUMENTS =
"metrics.reporter.arguments";
+ public static final String METRICS_REPORTER_CLASS = "class";
--- End diff --
I think we should label both class and interval as suffix keys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
