[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389539#comment-15389539
]
ASF GitHub Bot commented on FLINK-4246:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71882489
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -651,14 +651,38 @@
// ---------------------------- Metrics
-----------------------------------
+ // Per reporter:
+
+ /**
+ * The list of named reporters. Names are defined here and per-reporter
configs
+ * are given with the reporter config prefix and the reporter name.
+ *
+ * Example:
+ * <pre>{@code
+ * metrics.reporters = foo, bar
+ *
+ * metrics.reporter.foo.class = FooReporter.class
+ * metrics.reporter.foo.interval = 10
+ *
+ * metrics.reporter.bar.class = JMXReporter.class
+ * metrics.reporter.bar.port = 1337
+ * }</pre>
+ */
+ public static final String METRICS_REPORTERS_LIST = "metrics.reporters";
+
+ /**
+ * The prefix for per-reporter configs. Has to be combined with a
reporter name and
+ * the configs mentioned below.
+ */
+ public static final String METRICS_REPORTER_PREFIX =
"metrics.reporter.";
+
/** The class of the reporter to use. */
- public static final String METRICS_REPORTER_CLASS =
"metrics.reporter.class";
-
- /** A list of named parameters that are passed to the reporter. */
- public static final String METRICS_REPORTER_ARGUMENTS =
"metrics.reporter.arguments";
+ public static final String METRICS_REPORTER_CLASS = "class";
--- End diff --
I think we should label both class and interval as suffix keys.
> Allow Specifying Multiple Metrics Reporters
> -------------------------------------------
>
> Key: FLINK-4246
> URL: https://issues.apache.org/jira/browse/FLINK-4246
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Fix For: 1.1.0
>
>
> We should allow specifying multiple reporters. A rough sketch of how the
> configuration should look like is this:
> {code}
> metrics.reporters = foo,bar
> metrics.reporter.foo.class = JMXReporter.class
> metrics.reporter.foo.port = 42-117
> metrics.reporter.bar.class = GangliaReporter.class
> metrics.reporter.bar.port = 512
> metrics.reporter.bar.whatever = 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
