[
https://issues.apache.org/jira/browse/FLINK-25390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467967#comment-17467967
]
Francesco Guardiani commented on FLINK-25390:
---------------------------------------------
I suggest we introduce a sub interface of {{Factory}} that contains the method
{{mutableOptions}}, and then we use this interface both in dynamic table
sink/source factory and formats. I'll push a PR soon to show you.
> An alternative could also be that a format is always mutable.
If that's the case, we can just default implement the {{mutableOptions}} method
for encoding and decoding formats. But I'm not sure it's safe to assume that, I
did a quick scan of our formats and I don't see any format factory with an
option causing issues with the plan today, although the IGNORE_PARSE_ERRORS
used in json and other formats might be something we could evolve in future to
properly support error handling, ending up with plan changes (or better,
evolution).
In any case, let's think about this once we tackle
https://issues.apache.org/jira/browse/FLINK-25391.
> Support mutable options in DynamicTableFactory
> ----------------------------------------------
>
> Key: FLINK-25390
> URL: https://issues.apache.org/jira/browse/FLINK-25390
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Timo Walther
> Assignee: Francesco Guardiani
> Priority: Major
>
> Factory update for mutable options.
> {code}
> DynamicTableFactory {
> /* Declares options that can be modified without runtime implications. */
> Set<ConfigOption<?>> mutableOptions();
>
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
