slinkydeveloper opened a new pull request #18264:
URL: https://github.com/apache/flink/pull/18264


   ## What is the purpose of the change
   
   This PR contains several fixes to harden our json utilities and ser/de for 
the persisted plan
   
   ## Brief change log
   
   * Fix `JsonSerdeUtil` to create just one instance of `ObjectMapper`, as its 
allocation tends to be heavy and error prone. This also allows us to test in 
the unit tests the same `ObjectMapper` that is going to be used in the real 
environment (eventually testing conflicts of any kind)
   * Removed `FlinkDeserializationContext` as `SerdeContext` is now passed 
through the Jackson built-in `DeserializationContext`. Now `SerdeContext` is 
also passed to the serialization context.
   * Removed all usages of `ObjectMapper` within the `Deserializer`s, replacing 
them with proper usage of `DeserializationContext#readValue`.
   
   ## Verifying this change
   
   This change is a trivial rework without additional test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to