fapaul commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r778854403



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
                                                <artifactItem>
                                                        
<groupId>org.apache.kafka</groupId>
                                                        
<artifactId>kafka-clients</artifactId>
-                                                       <version>2.4.1</version>
+                                                       <version>2.8.1</version>
                                                        
<destFileName>kafka-clients.jar</destFileName>
                                                        <type>jar</type>
                                                        
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
                                                </artifactItem>
                                        </artifactItems>
                                </configuration>
                        </plugin>
+
+                       <!-- Skip dependency convergence check because of guava 
version -->
+                       <plugin>
+                               <groupId>org.apache.maven.plugins</groupId>
+                               <artifactId>maven-enforcer-plugin</artifactId>
+                               <executions>
+                                       <execution>
+                                               <id>dependency-convergence</id>
+                                               <goals>
+                                                       <goal>enforce</goal>
+                                               </goals>
+                                               <configuration>
+                                                       <skip>true</skip>
+                                               </configuration>
+                                       </execution>
+                               </executions>
+                       </plugin>

Review comment:
       @zentol although we also used it in kinesis for some reason what would 
be the right way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to