slinkydeveloper commented on a change in pull request #18272:
URL: https://github.com/apache/flink/pull/18272#discussion_r779000109
##########
File path: flink-examples/flink-examples-table/pom.xml
##########
@@ -53,34 +53,42 @@ under the License.
<version>${project.version}</version>
</dependency>
- <!-- Table connectors and formats -->
+ <!-- The following two dependencies are not required to define
a SQL job pipeline,
+ but only to execute it.
+
+ In particular, here we're forced to use
flink-table-planner_${scala.binary.version} instead of
+ flink-table-planner-loader, because otherwise you hit this bug
https://youtrack.jetbrains.com/issue/IDEA-93855
+ when trying to run the examples from within Intellij IDEA.
+
+ In a real environment, you need these dependencies only at test
scope, to execute the SQL job pipelines test.
+ -->
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-connector-files</artifactId>
+ <artifactId>flink-table-runtime</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-csv</artifactId>
+
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
Review comment:
I think it makes no difference, as this pom doesn't produce a fat jar.
In any case, I put it as provided more for documentation purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
