[ 
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391196#comment-15391196
 ] 

ASF GitHub Bot commented on FLINK-4226:
---------------------------------------

GitHub user nssalian opened a pull request:

    https://github.com/apache/flink/pull/2291

    FLINK-4226: Define Keys using Field Expressions example should use wi…

    Description:
    val wordCounts = words.keyBy("word").reduce(/*window specification*/)
    Should be: 
    val wordCounts = words.keyBy("word").reduce window(/window specification/)
    
    File:
    /flink/docs/apis/common/index.md
    
    Requesting Review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nssalian/flink FLINK-4226

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2291
    
----
commit a6bd8e2259f13b868afb97a0ba291ca39629e392
Author: Neelesh Srinivas Salian <[email protected]>
Date:   2016-07-24T23:02:12Z

    FLINK-4226: Define Keys using Field Expressions example should use window 
and not reduce

----


> Typo: Define Keys using Field Expressions example should use window and not 
> reduce
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-4226
>                 URL: https://issues.apache.org/jira/browse/FLINK-4226
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.0.3
>            Reporter: Ahmad Ragab
>            Priority: Trivial
>              Labels: documentation
>
> ...
> {code:java}
> val words: DataStream[WC] = // [...]
> val wordCounts = words.keyBy("word").window(/*window specification*/)
> // or, as a case class, which is less typing
> case class WC(word: String, count: Int)
> val words: DataStream[WC] = // [...]
> val wordCounts = words.keyBy("word").reduce(/*window specification*/)
> {code}
> Should be: 
> val wordCounts = words.keyBy("word").-reduce- window(/*window specification*/)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to