JingGe commented on a change in pull request #18105: URL: https://github.com/apache/flink/pull/18105#discussion_r779677500
########## File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SmokeKafkaITCase.java ########## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util.kafka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.connector.kafka.testutils.KafkaUtil; +import org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions; +import org.apache.flink.tests.util.TestUtils; +import org.apache.flink.tests.util.flink.JobSubmission; +import org.apache.flink.tests.util.flink.container.FlinkContainers; +import org.apache.flink.testutils.junit.FailsOnJava11; +import org.apache.flink.util.TestLoggerExtension; + +import org.apache.flink.shaded.guava30.com.google.common.collect.Lists; + +import org.apache.kafka.clients.CommonClientConfigs; +import org.apache.kafka.clients.admin.AdminClient; +import org.apache.kafka.clients.admin.NewTopic; +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.serialization.IntegerDeserializer; +import org.apache.kafka.common.serialization.IntegerSerializer; +import org.apache.kafka.common.serialization.VoidDeserializer; +import org.apache.kafka.common.serialization.VoidSerializer; +import org.junit.experimental.categories.Category; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.api.extension.RegisterExtension; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.KafkaContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; + +import java.nio.ByteBuffer; +import java.nio.file.Path; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.UUID; +import java.util.stream.Collectors; + +import static org.apache.flink.connector.kafka.testutils.KafkaUtil.createKafkaContainer; +import static org.apache.flink.util.DockerImageVersions.KAFKA; +import static org.assertj.core.api.Assertions.assertThat; + +/** smoke test for the kafka connectors. */ +@Category(value = {FailsOnJava11.class}) +@ExtendWith({TestLoggerExtension.class}) +@Testcontainers +public class SmokeKafkaITCase { + + private static final Logger LOG = LoggerFactory.getLogger(SmokeKafkaITCase.class); + private static final String INTER_CONTAINER_KAFKA_ALIAS = "kafka"; + private static final Network NETWORK = Network.newNetwork(); + + @Container + public static final KafkaContainer KAFKA_CONTAINER = + createKafkaContainer(KAFKA, LOG) + .withEmbeddedZookeeper() + .withNetwork(NETWORK) + .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS); + + @RegisterExtension + public static final FlinkContainers FLINK = + FlinkContainers.builder() + .setConfiguration(getConfiguration()) + .setLogger(LOG) + .dependsOn(KAFKA_CONTAINER) + .build(); + + private static AdminClient admin; + private static KafkaProducer<Void, Integer> producer; + + private static Configuration getConfiguration() { + // modify configuration to have enough slots + final Configuration flinkConfig = new Configuration(); + flinkConfig.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 3); + flinkConfig.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH, true); + return flinkConfig; + } + + @BeforeAll + private static void setUp() { + final Map<String, Object> adminProperties = new HashMap<>(); + adminProperties.put( + CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, + KAFKA_CONTAINER.getBootstrapServers()); + admin = AdminClient.create(adminProperties); + final Properties producerProperties = new Properties(); + producerProperties.putAll(adminProperties); + producerProperties.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, VoidSerializer.class); + producerProperties.put( + ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, IntegerSerializer.class); + producer = new KafkaProducer<>(producerProperties); + } + + @AfterAll + private static void teardown() { + admin.close(); + producer.close(); + } + + @Test + public void testKafka() throws Exception { + final Path kafkaExampleJar = TestUtils.getResource("flink-streaming-kafka-test.*"); Review comment: NIT: It is recommended to define a psfs constant at the top of the class for such hard coding string. ########## File path: flink-end-to-end-tests/flink-streaming-kafka-test/src/main/java/org/apache/flink/streaming/kafka/test/KafkaExample.java ########## @@ -17,29 +17,23 @@ package org.apache.flink.streaming.kafka.test; +import org.apache.flink.api.common.eventtime.WatermarkStrategy; import org.apache.flink.api.java.utils.ParameterTool; import org.apache.flink.connector.kafka.sink.KafkaRecordSerializationSchema; import org.apache.flink.connector.kafka.sink.KafkaSink; +import org.apache.flink.connector.kafka.source.KafkaSource; +import org.apache.flink.connector.kafka.source.enumerator.initializer.OffsetsInitializer; +import org.apache.flink.connector.kafka.source.reader.deserializer.KafkaRecordDeserializationSchema; import org.apache.flink.streaming.api.datastream.DataStream; import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; -import org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumer; -import org.apache.flink.streaming.kafka.test.base.CustomWatermarkExtractor; -import org.apache.flink.streaming.kafka.test.base.KafkaEvent; -import org.apache.flink.streaming.kafka.test.base.KafkaEventSchema; import org.apache.flink.streaming.kafka.test.base.KafkaExampleUtil; -import org.apache.flink.streaming.kafka.test.base.RollingAdditionMapper; import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.common.serialization.IntegerDeserializer; +import org.apache.kafka.common.serialization.IntegerSerializer; /** - * A simple example that shows how to read from and write to modern Kafka. This will read String - * messages from the input topic, parse them into a POJO type {@link KafkaEvent}, group by some key, - * and finally perform a rolling addition on each key for which the results are written back to - * another topic. - * - * <p>This example also demonstrates using a watermark assigner to generate per-partition watermarks - * directly in the Flink Kafka consumer. For demonstration purposes, it is assumed that the String - * messages are of formatted as a (word,frequency,timestamp) tuple. + * Forwards messages from one topic to another topic. Review comment: ```suggestion * A simple application used as smoke test example to forward messages from one topic to another topic in batch mode. ``` ########## File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SmokeKafkaITCase.java ########## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util.kafka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.connector.kafka.testutils.KafkaUtil; +import org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions; +import org.apache.flink.tests.util.TestUtils; +import org.apache.flink.tests.util.flink.JobSubmission; +import org.apache.flink.tests.util.flink.container.FlinkContainers; +import org.apache.flink.testutils.junit.FailsOnJava11; +import org.apache.flink.util.TestLoggerExtension; + +import org.apache.flink.shaded.guava30.com.google.common.collect.Lists; + +import org.apache.kafka.clients.CommonClientConfigs; +import org.apache.kafka.clients.admin.AdminClient; +import org.apache.kafka.clients.admin.NewTopic; +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.serialization.IntegerDeserializer; +import org.apache.kafka.common.serialization.IntegerSerializer; +import org.apache.kafka.common.serialization.VoidDeserializer; +import org.apache.kafka.common.serialization.VoidSerializer; +import org.junit.experimental.categories.Category; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.api.extension.RegisterExtension; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.KafkaContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; + +import java.nio.ByteBuffer; +import java.nio.file.Path; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.UUID; +import java.util.stream.Collectors; + +import static org.apache.flink.connector.kafka.testutils.KafkaUtil.createKafkaContainer; +import static org.apache.flink.util.DockerImageVersions.KAFKA; +import static org.assertj.core.api.Assertions.assertThat; + +/** smoke test for the kafka connectors. */ +@Category(value = {FailsOnJava11.class}) +@ExtendWith({TestLoggerExtension.class}) +@Testcontainers +public class SmokeKafkaITCase { + + private static final Logger LOG = LoggerFactory.getLogger(SmokeKafkaITCase.class); + private static final String INTER_CONTAINER_KAFKA_ALIAS = "kafka"; + private static final Network NETWORK = Network.newNetwork(); + + @Container + public static final KafkaContainer KAFKA_CONTAINER = + createKafkaContainer(KAFKA, LOG) + .withEmbeddedZookeeper() + .withNetwork(NETWORK) + .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS); + + @RegisterExtension + public static final FlinkContainers FLINK = + FlinkContainers.builder() + .setConfiguration(getConfiguration()) + .setLogger(LOG) + .dependsOn(KAFKA_CONTAINER) + .build(); + + private static AdminClient admin; + private static KafkaProducer<Void, Integer> producer; + + private static Configuration getConfiguration() { + // modify configuration to have enough slots + final Configuration flinkConfig = new Configuration(); + flinkConfig.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 3); + flinkConfig.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH, true); + return flinkConfig; + } + + @BeforeAll + private static void setUp() { + final Map<String, Object> adminProperties = new HashMap<>(); + adminProperties.put( + CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, + KAFKA_CONTAINER.getBootstrapServers()); + admin = AdminClient.create(adminProperties); + final Properties producerProperties = new Properties(); + producerProperties.putAll(adminProperties); + producerProperties.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, VoidSerializer.class); + producerProperties.put( + ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, IntegerSerializer.class); + producer = new KafkaProducer<>(producerProperties); + } + + @AfterAll + private static void teardown() { + admin.close(); + producer.close(); + } + + @Test + public void testKafka() throws Exception { + final Path kafkaExampleJar = TestUtils.getResource("flink-streaming-kafka-test.*"); + + final String inputTopic = "test-input-" + "-" + UUID.randomUUID(); + final String outputTopic = "test-output" + "-" + UUID.randomUUID(); + + // create the required topics + final short replicationFactor = 1; + admin.createTopics( + Lists.newArrayList( + new NewTopic(inputTopic, 1, replicationFactor), + new NewTopic(outputTopic, 1, replicationFactor))); + + producer.send(new ProducerRecord<>(inputTopic, 1)); + producer.send(new ProducerRecord<>(inputTopic, 2)); + producer.send(new ProducerRecord<>(inputTopic, 3)); + + // run the Flink job + FLINK.submitJob( + new JobSubmission.JobSubmissionBuilder(kafkaExampleJar) + .setDetached(false) + .addArgument("--input-topic", inputTopic) + .addArgument("--output-topic", outputTopic) + .addArgument("--prefix", "PREFIX") + .addArgument( + "--bootstrap.servers", + String.join( + ",", + KAFKA_CONTAINER.getBootstrapServers(), + KAFKA_CONTAINER.getNetworkAliases().stream() + .map( + host -> + String.join( + ":", + host, + Integer.toString(9092))) + .collect(Collectors.joining(",")))) + .addArgument("--group.id", "myconsumer") + .addArgument("--auto.offset.reset", "earliest") + .addArgument("--transaction.timeout.ms", "900000") + .addArgument("--flink.partition-discovery.interval-millis", "1000") + .build()); + final Properties consumerProperties = new Properties(); + consumerProperties.put( + CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, + KAFKA_CONTAINER.getBootstrapServers()); + consumerProperties.put( + ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, VoidDeserializer.class); + consumerProperties.put( + ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, IntegerDeserializer.class); + List<Integer> records = + KafkaUtil.drainAllRecordsFromTopic(outputTopic, consumerProperties).stream() + .map(r -> ByteBuffer.wrap(r.value()).getInt()) + .collect(Collectors.toList()); + assertThat(records).hasSize(3).containsExactly(1, 2, 3); + } Review comment: NIT: It is correct to keep the smoke test simple since it should focus on the fundamental/critical functions and run rapidly. Does resubmission check belong to such fundamental functions and should be done in this PR too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
