slinkydeveloper commented on a change in pull request #18283:
URL: https://github.com/apache/flink/pull/18283#discussion_r780306921
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactory.java
##########
@@ -148,7 +148,15 @@ public String factoryIdentifier() {
public DynamicTableSource createDynamicTableSource(Context context) {
final TableFactoryHelper helper =
FactoryUtil.createTableFactoryHelper(this, context);
- final ReadableConfig tableOptions = helper.getOptions();
+ final ReadableConfig tableOptions =
+ helper.forwardOptions(
+ TOPIC,
+ TOPIC_PATTERN,
+ SCAN_STARTUP_MODE,
+ SCAN_STARTUP_SPECIFIC_OFFSETS,
+ SCAN_TOPIC_PARTITION_DISCOVERY,
+ SCAN_STARTUP_TIMESTAMP_MILLIS)
+ .getOptions();
Review comment:
`forwardOptions` doesn't return anything, it's just a fluent method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
