slinkydeveloper commented on a change in pull request #17598: URL: https://github.com/apache/flink/pull/17598#discussion_r780071456
########## File path: flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/TableCsvFormatITCase.java ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.csv; + +import org.apache.flink.formats.common.TimeFormats; +import org.apache.flink.table.planner.runtime.utils.TestData; +import org.apache.flink.table.planner.utils.JavaScalaConversionUtil; +import org.apache.flink.table.planner.utils.JsonPlanTestBase; + +import org.junit.Test; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.flink.table.utils.DateTimeUtils.toLocalDateTime; + +/** Tests for the CSV file format. */ +public class TableCsvFormatITCase extends JsonPlanTestBase { + + @Test Review comment: Please let's keep `JsonPlanTestBase` and don't add a new test base. The test base you added is based on legacy as well (`TestValuesTableFactory`), and it's doing assertions based on strings while we want to use the new `TableAssertions`. So your new base will immediately become just another legacy to clean up later :smile:. We're planning to do proper rework of our bases and push them in the new `flink-table-test-utils`, and these needs to be independent of table planner, so connector and formats stop depending on table planner test classpath. If you wanna create a new test base, feel free to start from this point: push it to `flink-table-test-utils` and use the new `TableAssertions`. But I'm pretty sure it's quite some work, so no need to do it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
