Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2278#discussion_r72065910
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java
---
@@ -93,13 +90,12 @@ public boolean canMerge() {
@Override
public TriggerResult onMerge(W window, OnMergeContext ctx) throws
Exception {
TriggerResult triggerResult = nestedTrigger.onMerge(window,
ctx);
- switch (triggerResult) {
- case FIRE:
- return TriggerResult.FIRE_AND_PURGE;
- case FIRE_AND_PURGE:
- return TriggerResult.FIRE_AND_PURGE;
- default:
- return TriggerResult.CONTINUE;
+ if (triggerResult.isFire()) {
+ return TriggerResult.FIRE_AND_PURGE;
+ } else if (triggerResult.isPurge()) {
+ return TriggerResult.PURGE;
+ } else {
+ return TriggerResult.CONTINUE;
}
}
--- End diff --
Same as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
