zuston commented on a change in pull request #18220:
URL: https://github.com/apache/flink/pull/18220#discussion_r780378665
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -87,6 +87,6 @@ private YarnClusterDescriptor
getClusterDescriptor(Configuration configuration)
yarnConfiguration,
yarnClient,
YarnClientYarnClusterInformationRetriever.create(yarnClient),
- false);
+ true);
Review comment:
@tillrohrmann
Actually, it will occur that yarn client is closed by
`YarnClusterDescriptor` and but to use it when getting `RestClusterClient` from
`ClusterClientProvider`, please refer to
[code_link](https://github.com/apache/flink/blob/8b62a6267569bb417db21b75d5e6482341fea665/flink-clients/src/main/java/org/apache/flink/client/deployment/executors/AbstractJobClusterExecutor.java#L72)
To solve above problem, I introduce the `YarnClientRetrieve` to get yarn
client for `ApplicationReportProviderImpl`. When external yarn client is
closed, it will create new yarn
client that its lifecycle will be managed in this retriever.
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -87,6 +87,6 @@ private YarnClusterDescriptor
getClusterDescriptor(Configuration configuration)
yarnConfiguration,
yarnClient,
YarnClientYarnClusterInformationRetriever.create(yarnClient),
- false);
+ true);
Review comment:
Sorry i forget to revert it. Set it false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
