[ 
https://issues.apache.org/jira/browse/FLINK-21583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471278#comment-17471278
 ] 

liwei li commented on FLINK-21583:
----------------------------------

sorry for late. I ran the same case on 1.12.1 and got the same conclusion.:)
 

> Allow comments in CSV format without having to ignore parse errors
> ------------------------------------------------------------------
>
>                 Key: FLINK-21583
>                 URL: https://issues.apache.org/jira/browse/FLINK-21583
>             Project: Flink
>          Issue Type: Improvement
>          Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Table 
> SQL / Ecosystem
>    Affects Versions: 1.12.1
>            Reporter: Nico Kruber
>            Assignee: liwei li
>            Priority: Not a Priority
>              Labels: auto-deprioritized-major, auto-deprioritized-minor, 
> stale-assigned
>
> Currently, when you pass {{'csv.allow-comments' = 'true'}} to a table 
> definition, you also have to set {{'csv.ignore-parse-errors' = 'true'}} to 
> actually skip the commented-out line (and the docs mention this prominently 
> as well). This, however, may mask actual parsing errors that you want to be 
> notified of.
> I would like to propose that {{allow-comments}} actually also skips the 
> commented-out lines automatically because these shouldn't be used anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to