vahmed-hamdy commented on a change in pull request #17907:
URL: https://github.com/apache/flink/pull/17907#discussion_r781029925
##########
File path:
flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/resources/filter-large-orders.sql
##########
@@ -36,10 +36,10 @@ CREATE TABLE large_orders (
'connector' = 'kinesis',
'stream' = 'large_orders',
'aws.region' = 'us-east-1',
- 'sink.producer.verify-certificate' = 'false',
- 'sink.producer.kinesis-port' = '4567',
- 'sink.producer.kinesis-endpoint' = 'kinesalite',
- 'sink.producer.aggregation-enabled' = 'false',
Review comment:
The support for old sink is only by supporting deprecated options for
backward compatibility as discussed on
[FLINK-24905](https://issues.apache.org/jira/browse/FLINK-24905). The only
difference of flow between the 2 tests mentioned is mapping the deprecated
options but they will both use the new sink implementation. I doubt the old
test is needed.
PS: the fallback options mapping is tested in IT tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
