alpreu commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1008866360
> I believe it is the right direction to use the `KubernetesLabel` for generating and validating labels and names. I have one more concern about this PR. IIRC, only the labels, pod names, service names have the limitation of 63 characters. The ConfigMap name is not one of them. You are right about the configmap-affixes, we could remove them from the Enum. I think the question is if we want to have the generation in one place or not. > Another thing is about the pod name. The names of JobManager pod(e.g. `<clusterId>-fd5c8ffc4-c6dfw`) and TaskManager pod(e.g. `<clusterId>-taskmanager-<attemptId>-<index>`) are generated dynamically. Do we also need to add the limitation check for them? As far as I could see both of those only relate to configmaps or podnames, which should support a maximum of 253 characters. So if we discount the -taskmanger- (13 chars) and the current maximum for the clusterId (40chars) we still have 200 characters left so it should not be an issue. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
