fapaul commented on a change in pull request #18302: URL: https://github.com/apache/flink/pull/18302#discussion_r781227987
########## File path: flink-core/src/main/java/org/apache/flink/api/common/operators/ProcessingTimeService.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.operators; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.IOException; +import java.util.concurrent.ScheduledFuture; + +/** + * A service that allows to get the current processing time and register timers that will execute + * the given {@link ProcessingTimeCallback} when firing. + */ +@PublicEvolving +public interface ProcessingTimeService { Review comment: The idea here is to decouple the internal `ProcessingTimeService` from the one we want to expose. The internal one for example implements `ProcessingTimeService#quiesce` which we should not expose to the user. Regarding the methods, you have mentioned we can migrate them in the future to the public `ProcessingTimeService` but currently I do not see the need yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
