Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2278#discussion_r72080362
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java
---
@@ -114,8 +115,8 @@ private void runTest(
windowedStream =
windowedStream.allowedLateness(Time.milliseconds(ALLOWED_LATENESS_MS));
}
- if (!PURGE_WINDOW_ON_FIRE) {
- windowedStream = windowedStream.trigger(new
NonPurgingEventTimeTriggerWrapper());
+ if (PURGE_WINDOW_ON_FIRE) {
+ windowedStream =
windowedStream.trigger(PurgingTrigger.of(EventTimeTrigger.create()));
}
--- End diff --
Previously, the correct behavior in the case was still under discussion and
not clearly defined. This is why this branch of the test could not yet be
properly implemented and should fail as notification that it needs to be
adapted once the final behavior is defined.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
