wenlong88 commented on a change in pull request #18215:
URL: https://github.com/apache/flink/pull/18215#discussion_r781777506
##########
File path:
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/nodes/exec/stream/MatchRecognizeJsonPlanTest_jsonplan/testMatch.out
##########
@@ -427,7 +463,7 @@
"cid" : "BIGINT"
} ]
},
- "description" : "Match(orderBy=[proctime ASC], measures=[FINAL(A\".id) AS
aid, FINAL(l.id) AS bid, FINAL(C.id) AS cid], rowsPerMatch=[ONE ROW PER MATCH],
after=[SKIP TO NEXT ROW], pattern=[((_UTF-16LE'A\"', _UTF-16LE'l'),
_UTF-16LE'C')], define=[{A\"==(LAST(*.$1, 0), _UTF-16LE'a'), l==(LAST(*.$1, 0),
_UTF-16LE'b'), C==(LAST(*.$1, 0), _UTF-16LE'c')}])"
+ "description" : "Match(orderBy=[proctime ASC],
measures=[FINAL(FINAL(A\".id)) AS aid, FINAL(FINAL(l.id)) AS bid,
FINAL(FINAL(C.id)) AS cid], rowsPerMatch=[ONE ROW PER MATCH], after=[SKIP TO
NEXT ROW], pattern=[((_UTF-16LE'A\"', _UTF-16LE'l'), _UTF-16LE'C')],
define=[{A\"==(LAST(*.$1, 0), _UTF-16LE'a'), l==(LAST(*.$1, 0), _UTF-16LE'b'),
C==(LAST(*.$1, 0), _UTF-16LE'c')}])"
Review comment:
It is initially because we add validation on the query of insert which
is ignored before.
I finally found out that the root cause and fixed in the latest commit: when
converting sql node to operation, the query of insert would be validated twice
and the validator (in SqlValidatorImpl#navigationInMeasure) rewrite the FINAL
call twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
