fapaul commented on a change in pull request #18319:
URL: https://github.com/apache/flink/pull/18319#discussion_r781905027
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaCommitterTest.java
##########
@@ -60,6 +61,8 @@ public void testRetryCommittableOnRetriableError() throws
IOException {
new KafkaCommittable(PRODUCER_ID, EPOCH,
TRANSACTIONAL_ID, recyclable));
producer.resumeTransaction(PRODUCER_ID, EPOCH);
List<KafkaCommittable> recovered = committer.commit(committables);
+ // FLINK-25531: force the producer to close immediately, else it
would take 1 hour
+ producer.close(Duration.ZERO);
Review comment:
Nit: I think it would be better to move this statement after the
assertions to make clear it has nothing to do with the test behavior and only
should increase the shutdown speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
