fapaul commented on pull request #18325: URL: https://github.com/apache/flink/pull/18325#issuecomment-1009807430
> How did you decide which classes should be public? I see that `Metric` and all extending interfaces are `Public`, yet `View` isn't despite being an extension for metrics. > > Why are the reporter interfaces not annotated? Good question, I mainly went through the metrics classes relevant for connectors. Do you think all classes inside the `metrics-core` module should be annotated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
