dannycranmer commented on a change in pull request #18022:
URL: https://github.com/apache/flink/pull/18022#discussion_r782002482
##########
File path:
flink-end-to-end-tests/flink-glue-schema-registry-avro-test/src/test/java/org/apache/flink/glue/schema/registry/test/GlueSchemaRegistryAvroKinesisITCase.java
##########
@@ -125,25 +133,18 @@ public void testGSRAvroGenericFormatWithFlink() throws
Exception {
}
log.info("results: {}", results);
- Assert.assertEquals(
- "Results received from '" + OUTPUT_STREAM + "': " + results,
- messages.size(),
- results.size());
- Assert.assertTrue(messages.containsAll(results));
+ assertThat(results).isEqualTo(messages);
Review comment:
Yes, good point since Kinesis does not guarantee ordering 👍
##########
File path:
flink-end-to-end-tests/flink-glue-schema-registry-json-test/src/test/java/org/apache/flink/glue/schema/registry/test/json/GlueSchemaRegistryJsonKinesisITCase.java
##########
@@ -122,11 +128,7 @@ public void testGSRJsonGenericFormatWithFlink() throws
Exception {
}
log.info("results: {}", results);
- Assert.assertEquals(
- "Results received from '" + OUTPUT_STREAM + "': " + results,
- messages.size(),
- results.size());
- Assert.assertTrue(messages.containsAll(results));
+ assertThat(results).isEqualTo(messages);
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
