dmvk commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r782116207
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -63,6 +63,7 @@ public MiniDispatcher(
rpcService,
fencingToken,
Collections.singleton(jobGraph),
+ Collections.emptyList(),
Review comment:
The JRS is meant to be scoped per cluster (basically the full job
identifier should be tuple of `(clusterId, jobId)`). Future extension would be
for example persisting the information that the cluster should shut down (this
is needed to make shutdown in multi JM setup bullet proof).
Also with the application mode, the jobIds could easily clash as the fixed
jobId is used there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
