zuston commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r782169884
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -44,7 +41,6 @@ public boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
}
- @Nonnull
public LocalRecoveryDirectoryProvider getLocalStateDirectoryProvider() {
Review comment:
The signature of optional may be a better option. We could use
orElseThrow to throw exceptions although it should not happen when enabled task
local recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
