tillrohrmann commented on a change in pull request #18220: URL: https://github.com/apache/flink/pull/18220#discussion_r782848602
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClientRetrieverImpl.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.service.Service; +import org.apache.hadoop.yarn.client.api.YarnClient; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.hadoop.yarn.client.api.YarnClient.createYarnClient; + +/** + * The implementation of {@link YarnClientRetriever} which is used to get yarn client for {@link + * ApplicationReportProviderImpl}. When external yarn client is closed, it will create new yarn + * client that its lifecycle will be managed in this retriever. + */ +@Internal +public final class YarnClientRetrieverImpl implements YarnClientRetriever { + private static final Logger LOG = LoggerFactory.getLogger(YarnClientRetrieverImpl.class); + + private final YarnClient externalYarnClient; + private final YarnConfiguration yarnConfiguration; + private YarnClient createdYarnClient; + + private YarnClientRetrieverImpl(YarnClient yarnClient, YarnConfiguration yarnConfiguration) { + this.externalYarnClient = yarnClient; + this.yarnConfiguration = yarnConfiguration; + } + + @Override + public YarnClient getYarnClient() { + if (externalYarnClient != null && !externalYarnClient.isInState(Service.STATE.STOPPED)) { + return externalYarnClient; + } + + if (createdYarnClient != null) { + return createdYarnClient; Review comment: Can't the retriever return a `YarnClientWrapper` that allows us to close it? In that sense, the retriever would be like a supplier and it would wrap the internal yarn client that cannot be close via the `YarnClientWrapper`. Only if the supplier has created a dedicated `yarnClient`, the close operation won't be a no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
