zentol commented on a change in pull request #18334:
URL: https://github.com/apache/flink/pull/18334#discussion_r782905546
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClientTest.java
##########
@@ -236,16 +236,19 @@ public void testAcknowledgeAllRecordsProcessed() throws
Exception {
private NettyPartitionRequestClient createPartitionRequestClient(
Channel tcpChannel, NetworkClientHandler clientHandler) throws
Exception {
- int port = NetUtils.getAvailablePort();
- ConnectionID connectionID = new ConnectionID(new
InetSocketAddress("localhost", port), 0);
- NettyConfig config =
- new NettyConfig(InetAddress.getLocalHost(), port, 1024, 1, new
Configuration());
- NettyClient nettyClient = new NettyClient(config);
- PartitionRequestClientFactory partitionRequestClientFactory =
- new PartitionRequestClientFactory(nettyClient);
-
- return new NettyPartitionRequestClient(
- tcpChannel, clientHandler, connectionID,
partitionRequestClientFactory);
+ try (NetUtils.Port availablePort = NetUtils.getAvailablePort()) {
+ int port = availablePort.getPort();
+ ConnectionID connectionID =
+ new ConnectionID(new InetSocketAddress("localhost", port),
0);
+ NettyConfig config =
+ new NettyConfig(InetAddress.getLocalHost(), port, 1024, 1,
new Configuration());
Review comment:
Also works with port 0...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
