wsry commented on a change in pull request #17814:
URL: https://github.com/apache/flink/pull/17814#discussion_r783667878
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/runtime/ShuffleCompressionITCase.java
##########
@@ -84,8 +84,6 @@
@Test
public void testDataCompressionForBoundedBlockingShuffle() throws
Exception {
Review comment:
After changing the default value to true, I guess many test cases
including BlockingShuffleITCase have already covered the scenario of data
compression. Here what we really need is a test case which covers the scenario
where data is not compressed. Could you please change the method name including
the below one to something like
testBoundedBlockingShuffleWithoutCompression/testSortMergeBlockingShuffleWithoutCompression,
and set the bool flag of data compression to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
